Skip to content

Use static string path imports to load the platform-specific implementations. #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sindresorhus merged 2 commits into from
Sep 18, 2025
Merged

Use static string path imports to load the platform-specific implementations. #131

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ee611b9
Use static string path imports to load the platform-specific implemen…
lgarron Sep 17, 2025
35ab1ce
Update index.js
sindresorhus Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,11 +61,23 @@ export default async function trash(paths, options = {}) {
return;
}

// Load platform-specific implementation
const platform = process.platform === 'darwin'
? 'macos'
: (process.platform === 'win32' ? 'windows' : 'linux');

const {default: trashFunction} = await import(`./lib/${platform}.js`);
const {default: trashFunction} = await platformSpecificImplementation();
return trashFunction(resolvedPaths);
}

// We use static imports so it can be statically analyzed.
async function platformSpecificImplementation() {
switch (process.platform) {
case 'darwin': {
return import('./lib/macos.js');
}

case 'win32': {
return import('./lib/windows.js');
}

default: {
return import('./lib/linux.js');
}
}
}