Encode .trashinfo Path with encodeURI as per XDG spec#134
Merged
sindresorhus merged 1 commit intosindresorhus:mainfrom Dec 7, 2025
Merged
Encode .trashinfo Path with encodeURI as per XDG spec#134sindresorhus merged 1 commit intosindresorhus:mainfrom
sindresorhus merged 1 commit intosindresorhus:mainfrom
Conversation
The [XDG trash spec](https://specifications.freedesktop.org/trash/1.0/) requires the .trashinfo Path= entry to be percent-encoded (RFC 2396). The current implementation encodes only spaces, not other characters. This impacts files with special / non-ASCII characters in their names. This change: - Use encodeURI(filePath) to encoded paths properly (not just spaces). - Updates the `create trashinfo` test to validate `'f2 ^'` instead of `'f2'`, introducing a special character in addition to space. - Update README XDG spec link to the current official trash spec URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The XDG trash spec requires the .trashinfo Path= entry to be percent-encoded (RFC 2396).
The current implementation encodes only spaces, not other characters. This impacts files with special / non-ASCII characters in their names.
This change:
create trashinfotest to validate'f2 ^'instead of'f2', introducing a special character in addition to space.