Parma.py update to include unified campaign name and org currency #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m consts for dimensions
RubyFeinstein
suggested changes
Sep 26, 2018
There was a problem hiding this comment.
We're not adding any dimensions that are not officially supported.
The list of officially supported dimensions are available in https://developers.singular.net/v2.0/reference.
If you think that these dimensions should become officially supported you need to consult with the product team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added "organization_currency" and "unified_campaign_name" to the param consts for dimensions
@shoote Please merge this if you are ok with the change, can you then publish a new versions in pypi