Fix critical bugs, JDK 8-25 compatibility, add tests and new features - #1
Merged
Merged
Conversation
Bug fixes:
- Fix duplicate condition in RollingFileSink.alignCurrentFileTo
- Fix BooleanScalarConversionPolicy not setting result.result
- Fix inverted TemporalAccessor format condition in ScalarValue
- Fix LogEventProperty.isValidName accepting invalid names
- Fix typo remotePropertyIfPresent -> removePropertyIfPresent
- Fix invalid format strings in PropertyBinder (%1, {0} -> %s)
- Implement file size limit check in FileSink
JDK compatibility:
- Wrap setAccessible in try-catch for JDK 16+ in Reflection
- Replace new Integer(c) with (int) c in JsonFormatter
- Use StandardCharsets.UTF_8 in SeqSink
- Update Maven Compiler Plugin to 3.13.0
Resource leaks and thread safety:
- Fix SeqSink: try-with-resources, disconnect, StringBuilder
- Set output=null on FileSink.close
- Replace HashMap+synchronized with ConcurrentHashMap in MessageTemplateCache
- Add volatile to Log._logger
- Use ConcurrentHashMap+computeIfAbsent in EnumScalarConversionPolicy
- ThreadLocal for SimpleDateFormat in JsonFormatter
New features:
- Enrichers: ThreadId, ThreadName, MachineName, ProcessId
- ConsoleSink (plain, no ANSI) with configurator
- AsyncWrapperSink with BlockingQueue and daemon thread
- Minimum level override by source context
- PropertiesFileConfiguration and SinkRegistry
Testing:
- Add JUnit 5 and Surefire Plugin
- Add InMemorySink for testing
- Add 50 tests across 9 test classes
- Add CI workflow for JDK 8/11/17/21/25 matrix
Tested locally on JDK 8, 17, and 25 - all 50 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes:
JDK compatibility:
Resource leaks and thread safety:
New features:
Testing:
Tested locally on JDK 8, 17, and 25 - all 50 tests pass.