Add files via upload#4
Open
frankliuyc wants to merge 2 commits into
Open
Conversation
Owner
|
@frankliuyc One suggestion. You've coded in an implicit assumption that tensors that aren't the right shape should be modified in the 0th dimension. I would add in some kind of check that every other dim has the same size (except dim=0) before filling. Otherwise, looks great! Almost ready to pull. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1
filter_state_dict(model, stashed_dict, fill_tensor=False)will now reshape branched layer weight/bias to accommodate additional branches whenfill_tensor=True