feat: implement Liquidity functions with tests#103
Conversation
There was a problem hiding this comment.
why did you remove this swap_exact_tokens_for_tokens() and this function get_swap_rate()
There was a problem hiding this comment.
I can't see your test file
There was a problem hiding this comment.
- I'll add test soon.
- I commented out those functions because
scarbcomplains of missing traits implementation.
|
@GoSTEAN I read your project README and I figured you wanted a real ERC20 tokens minted to liquidity providers when they add liquidity. But, my current implementation just mints internal LP tokens whose balance are managed by the contract. As there is no pool, pair and factory contracts in the repo to (dynamically) deploy LP token contract per pool , I am working on a simple way to achieve this while meeting InheritX project's objectives. Then tests will easily be applied! |
|
@emarc99 How is this going? |
|
Going quite well. To ensure compatibility, I am working on below issue simultaneously. Would love to be assigned to that as well when this is merged; |
|
Just finish with one first please |
|
@emarc99 can this be done by tomorrow? Because you have held this for so long (2 weeks) |
|
On it right now. I'll open the PR by tomorrow morning at the latest, after I reviewed it. |
|
Apologies for the delay, I was trying out something I ultimately just concluded is not required right now. |
|
Opening PR any moment, looking at any more tests that can be added.... |
emarc99
changed the title
Your TG handle |
|
TG: emarc99 |
2 participants
Uh oh!
There was an error while loading. Please reload this page.