Skip to content

Fix/ Users should not provide their role when signing up #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Abeeujah merged 1 commit into from
Jun 6, 2025
Merged

Fix/ Users should not provide their role when signing up #11

Abeeujah merged 1 commit into from
Jun 6, 2025

Conversation

@amasscyberworld
Copy link
Contributor

@amasscyberworld amasscyberworld commented Jun 5, 2025 

Users are no longer able to specify their role during the signup process.
All newly registered users are automatically assigned a predefined default, non-privileged role.
Existing functionality related to signup remains intact (excluding the role assignment by the user).
The changes are thoroughly tested.
Relevant documentation is updated.

Abeeujah
Abeeujah reviewed Jun 6, 2025
View reviewed changes
Copy link
Contributor

@Abeeujah Abeeujah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to Go

coverage/clover.xml
<project timestamp="1749115806127" name="All files">
<metrics statements="0" coveredstatements="0" conditionals="0" coveredconditionals="0" methods="0" coveredmethods="0" elements="0" coveredelements="0" complexity="0" loc="0" ncloc="0" packages="0" files="0" classes="0"/>
</project>
</coverage>
Copy link
Contributor

@Abeeujah Abeeujah Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job 👍

src/__tests__/controllers/auth.controller.test.js
await expect(registerUser(req, res)).rejects.toThrow('User already exists');
expect(res.status).toHaveBeenCalledWith(400);
});
});
Copy link
Contributor

@Abeeujah Abeeujah Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool with the tests 👍

src/controllers/auth.controller.js
role,
role: 'user',
});

Copy link
Contributor

@Abeeujah Abeeujah Jun 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Abeeujah Abeeujah self-requested a review June 6, 2025 09:39
@Abeeujah Abeeujah merged commit 7b3bcda into skill-mind:master Jun 6, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Abeeujah Abeeujah Abeeujah approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amasscyberworld @Abeeujah