-
Couldn't load subscription status.
- Fork 723
[ENH] add feature scaling support for EncoderDecoderDataModule
#1983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PranavBhatP
wants to merge
9
commits into
sktime:main
Choose a base branch
from
PranavBhatP:feature-scaling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
49c3ab4
add feature scaling to d2
PranavBhatP 1942383
Merge branch 'main' into feature-scaling
PranavBhatP 403e0f2
fix incorrect orig_idx index
PranavBhatP 5661be4
fix incorrect attibute
PranavBhatP 38cefe4
handle unfitted scalers
PranavBhatP f242290
change accelerator to cpu in v2 notebook cell 10
PranavBhatP 54da1c4
use torch.from_numpy instead of torch.tensor for numpy to torch conve…
PranavBhatP c145e9b
revert accelerator mode to auto from cpu for example notebook trainin…
PranavBhatP ec4cf03
potential fix for issue in trainingof v2
PranavBhatP File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have doubt: Wouldn't using
detachagain detach the tensor from the computation graph? That would again lead to the same issue?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as my knowledge of pytorch goes, I think it's a good practice to use
.detach()before converting the pytorch tensor to a numpy array. Anyways, the numpy array will not track the gradients, so this won't matter.