Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exposing native services #220

Merged
merged 2 commits into from
Sep 2, 2024
Merged

exposing native services #220

merged 2 commits into from
Sep 2, 2024

Conversation

pwright
Copy link
Member

@pwright pwright commented Feb 13, 2024

addresses #202

@pwright
Copy link
Member Author

pwright commented Apr 17, 2024

@fgiorgetti Is this worth including?

@pwright pwright requested a review from fgiorgetti April 17, 2024 12:40
skitt
skitt reviewed Aug 9, 2024
View reviewed changes
cli/podman.adoc Outdated Show resolved Hide resolved
@fgiorgetti
Copy link
Member

@pwright Why not using host.containers.internal as the hostname to be exposed?
Podman adds it to the /etc/hosts of each container. It is (possibly) the first IP found
(excluding loopback), but I believe it is easier to use.

@pwright pwright force-pushed the expose-service-podman branch from 6971b60 to 8fd1652 Compare August 29, 2024 15:41
@pwright
Copy link
Member Author

pwright commented Aug 30, 2024

@pwright Why not using host.containers.internal as the hostname to be exposed?
@fgiorgetti updated to use your suggestion

@pwright pwright merged commit 26bf4af into skupperproject:main Sep 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skitt skitt skitt left review comments

@fgiorgetti fgiorgetti fgiorgetti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pwright @fgiorgetti @skitt