Skewer adaptation #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssorj
reviewed
Mar 7, 2022
.gitmodules
Outdated
| @@ -0,0 +1,3 @@ | |||
| [submodule "skewer"] | |||
There was a problem hiding this comment.
I think we should consider using git-subrepo instead. The main reason is simply that it avoids one extra step for the user. But let me know if you tried it and prefer submodules.
There was a problem hiding this comment.
There was a problem hiding this comment.
Changed to git-subrepo, thanks for the instructions!
| - run: "INSERT INTO product VALUES(DEFAULT, 'Orange', '4056');" | ||
| postamble: | | ||
| From any cluster, access the `product` tables in the `markets` database to view contents. | ||
| summary: | |
There was a problem hiding this comment.
The summary is rendered at the end, so this text should either go back to the start (the overview) or be recast as "what you did", not what you will do.
…kewer subrepo: subdir: "subrepos/skewer" merged: "3c2a955" upstream: origin: "https://github.com/skupperproject/skewer" branch: "main" commit: "3c2a955" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated README file using the Skewer project.