-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update links from /v2/ to /main/ #1901
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Paul, looks good to me. I will add @c-kruse to double-check the network observer part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Paul! Just those two false positives made it in, but otherwise looks good to me!
@@ -1,5 +1,5 @@ | |||
package main | |||
|
|||
//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=.oapi-codegen.cfg ./spec/openapi.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a different v2!
@@ -3,5 +3,5 @@ | |||
package main | |||
|
|||
import ( | |||
_ "github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen" | |||
_ "github.com/oapi-codegen/oapi-codegen/main/cmd/oapi-codegen" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one also should not be changed
@nluaces does this make sense? or too broad?