Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update links from /v2/ to /main/ #1901

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pwright
Copy link
Member

@pwright pwright commented Jan 22, 2025

@nluaces does this make sense? or too broad?

Copy link
Member

@nluaces nluaces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Paul, looks good to me. I will add @c-kruse to double-check the network observer part.

@nluaces nluaces requested a review from c-kruse January 22, 2025 13:36
Copy link
Contributor

@c-kruse c-kruse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul! Just those two false positives made it in, but otherwise looks good to me!

@@ -1,5 +1,5 @@
package main

//go:generate go run github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen --config=.oapi-codegen.cfg ./spec/openapi.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a different v2!

@@ -3,5 +3,5 @@
package main

import (
_ "github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen"
_ "github.com/oapi-codegen/oapi-codegen/main/cmd/oapi-codegen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one also should not be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants