-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use embedded dmsghttp config for dmsg utilities [WIP] #298
Open
0pcom
wants to merge
14
commits into
skycoin:develop
Choose a base branch
from
0pcom:dmsghttp-embedded
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mrpalide I have significantly refactored the code for dmsgcurl. Can you check on this error? I can't seem to figure it out This will produce the error
Error not present with the -z flag which is the original / previous behavior of dmsgcurl, using the dmsg-discovery as normal
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this attempts to add to dmsg functionality that currently exists for skywire. Using the embedded dmsg servers of the dmsghttp-config.json it should be possible to connect to dmsg without http request to the dmsg discovery.
Testing
the default behavior is to avoid http requests. The
-z
flag switches to using http request & the discovery.It's not yet working