feat(drawer): add ?view=yaml URL deep link for resource drawer#677
Open
nadaverell wants to merge 1 commit into
Open
feat(drawer): add ?view=yaml URL deep link for resource drawer#677nadaverell wants to merge 1 commit into
nadaverell wants to merge 1 commit into
Conversation
Lets users bookmark or share a URL that opens the resource drawer straight into YAML view, e.g.: /resources/pods?resource=ns/name&view=yaml State stays in sync with the URL: toggling YAML on/off in the drawer adds/removes ?view=yaml; closing the drawer clears it. Normal row clicks (no ?view) still open in detail mode as before. Wiring: - WorkloadView fires a new onYamlChange callback whenever the drawer YAML toggle flips - ResourceDetailDrawer threads it through the children render prop - App.tsx subscribes (writes URL) and reads ?view=yaml on mount when restoring ?resource= from a deep link
|
You have used all Bugbot PR reviews included in your free trial for your GitHub account on this workspace. To continue using Bugbot reviews, enable Bugbot for your team in the Cursor dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lets users bookmark or share a URL that opens the resource drawer straight into YAML view, e.g.:
/resources/pods?resource=ns/name&view=yamlState stays in sync with the URL: toggling YAML on/off in the drawer adds/removes
?view=yaml; closing the drawer clears it. Normal row clicks (no?view) still open in detail mode as before.Wiring
WorkloadViewfires a newonYamlChange?(yaml)callback whenever the drawer YAML toggle flips (called fromswitchView).ResourceDetailDrawerthreads it through the children render prop.App.tsxsubscribes to write the URL, and reads?view=yamlon mount when restoring?resource=from a deep link.?view=is also used byTimelineViewforlist|swimlane, but the two routes are mutually exclusive andApp.tsxstrips view-specific params on view change, so there's no leak. TimelineView's value cast falls back toundefinedif the param doesn't match.Verified
?view=yaml→ drawer opens directly to YAML?viewcleared?view) → opens in detail mode (no YAML)