k8s-ui: label the expanded issue categories (fix acronym title-casing)#920
Merged
Conversation
categoryLabel's CATEGORY_LABEL map was missing 10 categories from the issues catalog expansion (pv_failed, pvc_resize_failed, secret_sync_failed, load_balancer_pending, gateway_not_ready, gateway_route_invalid, node_provisioning_failed, apiservice_unavailable, crossplane_reconcile_failed, termination_stuck). They fell back to generic title-casing that mangled acronyms — 'Pv failed', 'Pvc resize failed'. Add explicit labels with correct casing (PV / PVC / APIService) so the Issues registry + queue render right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Issues catalog grew to ~49 categories, but
categoryLabel'sCATEGORY_LABELmap inseverity.tswas never extended to match. The 10 newest categories fell through to the generichumanize()fallback, which title-cases the snake_case key and mangles acronyms —pv_failedrendered as "Pv failed",pvc_resize_failedas "Pvc resize failed", while the olderpvc_pendingcorrectly showed "PVC pending". This is visible anywhere the label is shown (the Radar Hub Issues settings registry + the fleet Issues queue).What changed
Added explicit labels for the 10 unmapped categories with correct casing:
pv_failed→ "PV failed",pvc_resize_failed→ "PVC resize failed",apiservice_unavailable→ "APIService unavailable", plussecret_sync_failed,load_balancer_pending,gateway_not_ready,gateway_route_invalid,node_provisioning_failed,crossplane_reconcile_failed,termination_stuck. The map is now complete against the catalog (no category falls back to title-casing).Testing
Cross-checked every catalog category key against the map — all 49 now have an explicit label.
Notes
Consumed by
radar-hub-web(the Issues settings/queue). It needs a@skyhook-io/k8s-uipublish + a pin bump there before the corrected labels reach that UI.