fix(deps): drop stray semver build metadata from toml's version requirement - #54
Merged
Merged
Conversation
…rement PR #51's dependency bump carried "+spec-1.1.0" (toml's semver BUILD metadata, meaningful only for the exact resolved version) into the version REQUIREMENT string in [workspace.dependencies], where it's meaningless - cargo ignores it and warns on every build/doc invocation in the 3 tool crates that depend on toml directly ("version requirement ... includes semver metadata which will be ignored"). toml = "1.1.3" is the correct requirement; Cargo.lock still resolves to the exact 1.1.3+spec-1.1.0 build either way. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Found while auditing whether every gate this template preaches is actually clean on the template's own `main`. `cargo doc` was emitting a manifest warning across 3 tool crates: `version requirement `1.1.3+spec-1.1.0` for dependency `toml` includes semver metadata which will be ignored`.
Root cause: #51's dependency bump carried toml's semver build metadata (`+spec-1.1.0`, meaningful only for the exact resolved version in Cargo.lock) into the version requirement string in `[workspace.dependencies]`, where it's meaningless. `toml = "1.1.3"` is correct; Cargo.lock still resolves the exact `1.1.3+spec-1.1.0` build either way - no behavior change, purely removes a spurious warning.
Test plan