[ttpe] Add commons-logging depenency. #312
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skynavga
reviewed
Oct 14, 2022
ttt-ttpe-all/pom.xml
Outdated
| @@ -43,6 +44,11 @@ | |||
| <artifactId>icu4j</artifactId> | |||
| <version>${icu4j.version}</version> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
Please move this dependency to a profile, e.g.,
<profiles>
<profile>
<id>windows</id>
<dependencies>...</dependencies>
</profile>
</profiles>
then use -Pwindows when building.
There was a problem hiding this comment.
Also, please create an issue and refer to it from the description of this PR, e.g., "Closes #...".
There was a problem hiding this comment.
Thanks for your instructive review, applied all and tested again, should be fine.
ngaullier
force-pushed
the
Fix_win_build
branch
from
c852617 to
5f7e57c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a requirement when building in windows (I have also another issue with some tests that I need to bypass, but this is another topic and I have not determined the root cause, so cannot contribute it as is).