fix: stop logging bootstrap password as structured param + drop userCount from bootstrap-state#2
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…ount from bootstrap-state - UserService: emit generated break-glass password to stderr only (not through the Serilog pipeline) so structured sinks never index it (CWE-532). - AuthEndpoints: remove userCount from /api/auth/bootstrap-state — only ownerExists is needed for the bootstrap flow; the count was minor info disclosure on an endpoint reachable without a session. - hooks.ts: drop userCount from BootstrapState interface (unused). Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two security fixes found during a codebase audit:
1. Bootstrap password leaked to structured logging sinks (CWE-532)
UserService.BootstrapAsynclogged the generated break-glass password as a structured parameter{Password}, which Serilog (and any downstream sink — Seq, ELK, Datadog) indexes as a searchable field. The password now goes to stderr only (visible in the container's initial console output, not persisted by the logging pipeline):2.
/api/auth/bootstrap-statereturneduserCountwithout a sessionThe endpoint is reachable through the BFF without an active session (the BFF attaches the admin token but sets identity to Anonymous).
ownerExistsis needed for the bootstrap flow;userCountis not and leaks how many users exist. Removed the unnecessaryListAsync()call and theuserCountfield from the response + the frontendBootstrapStatetype.Link to Devin session: https://app.devin.ai/sessions/32fc2dfa3f9f4852af604fbaed8dca4c
Requested by: @skyp1nus