refactor: extract duplicated Slack/PacificTime code into SharedKernel utilities#3
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
refactor: extract duplicated Slack/PacificTime code into SharedKernel utilities#3devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
- PacificTime: centralized Pacific TZ logic in SharedKernel; modules delegate via thin facades preserving internal APIs - SlackSignatureVerifier: single sealed implementation in SharedKernel; deleted identical 36-line copies from both modules - SlackSocketModeServiceBase: abstract base class encapsulating ~130 lines of WebSocket transport (connection, reconnect, ACK, error isolation); modules subclass and implement DispatchEnvelopeAsync for their specific envelope routing Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates ~490 net lines of duplicated infrastructure between the YouTubeComments and YouTubeUploads modules by extracting three shared utilities into
Hookline.SharedKernel:1.
SharedKernel.Common.PacificTime— single source of truth for PT timezone logic (quota resets at PT midnight). Modules keep thin internal facades delegating to the shared impl:2.
SharedKernel.Slack.SlackSignatureVerifier— the identical 36-line HMAC-SHA256 + constant-time compare implementation was duplicated verbatim in both modules. Now a singlepublic sealed classin SharedKernel; modules register it directly via DI.3.
SharedKernel.Slack.SlackSocketModeServiceBase— abstractBackgroundServiceencapsulating ~130 lines of WebSocket transport (connection open, receive loop, ACK, reconnect, error isolation). Modules subclass and implement onlyDispatchEnvelopeAsync:Net diff: +179 / −668 lines. All existing tests and architecture constraints pass unchanged.
Link to Devin session: https://app.devin.ai/sessions/672d4d38efcc4a0cac0d2a6c297166ca
Requested by: @skyp1nus