Add structured logging to silently swallowed catch blocks#4
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Add structured logging to silently swallowed catch blocks#4devin-ai-integration[bot] wants to merge 1 commit into
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Inject ILogger into services with bare catch blocks and add structured log calls so failures leave a diagnostic trail: - RedisCachePurge: log cache purge failures at Warning - JobService: log audit-write failures at Warning - UploadJobHandler: log quota-release and mark-account-error failures at Debug/Warning - YouTubeUploadsProviderEndpoints: log OAuth start failures - QuotaService: log unit-charge failures at Warning - GoogleAccountsService: log channel-lookup failures at Warning All catches remain non-fatal (best-effort swallowing preserved); the only change is visibility via structured logging. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Several best-effort catch blocks swallowed exceptions with no logging at all — a Redis hiccup, a failed audit write, or a quota-release error would vanish silently, making production diagnosis impossible. This PR injects
ILogger<T>into those services and adds structured log calls so every swallowed failure leaves a trace.What changed (all catches remain non-fatal — only visibility is added):
Test constructors updated to pass
NullLogger<T>.Instancefor the new parameters. All 234 tests pass.Link to Devin session: https://app.devin.ai/sessions/0b54f37fe20049d0a218def75b07b0c0
Requested by: @skyp1nus