Skip to content

populate default Build version if missing #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

wadey
Copy link
Member

@wadey wadey commented Apr 8, 2025

Use the Go module information built into the binary if the Build var wasn't set during the build.

This means if you install via a specific tag, you get:

go install github.com/slackhq/nebula/cmd/[email protected]

$ nebula -version
Version: 1.9.5

And if you install master, you get:

go install github.com/slackhq/nebula/cmd/nebula@master

$ nebula -version
Version: 1.9.5-0.20250408154034-18279ed17b10

Use the Go module information built into the binary if the Build var
wasn't set during the build.

This means if you install via a specific tag, you get:

    go install github.com/slackhq/nebula/cmd/[email protected]

    $ nebula -version
    Version: 1.9.5

And if you install master, you get:

    go install github.com/slackhq/nebula/cmd/nebula@master

    $ nebula -version
    Version: 1.9.5-0.20250408154034-18279ed17b10
@wadey
Copy link
Member Author

wadey commented Apr 14, 2025

I guess we should also do this higher up in the nebula library to also work when folks are using Nebula as a library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant