Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runner AST (visualization)
Previously, the AST using the runner was not keyboard accessible/did not have many of the features the interactive pane AST had. Additions to ast.ts were made to enable keyboard navigation. It also now supports a feature which when a node is clicked, moves the cursor in the code editor to the beginning of that node(ast.ts and ide.ts). The runner tree was also updated to have more simple graphics instead of extraneous lines(runner.html).
General AST
ast.ts was updated to provide more accurate descriptions of scamper code. The tree is now output with more syntactically meaningful labels.
Other fix
Key binds were reorganized to provide more universally usable keys. ide.html was changed to support these new key binds. Also, the indentation on ast.ts was set to 4, and nearly everything else is 2, so everything was reindented.