-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create .htaccess and updated public/.htaccess #213
Conversation
RewriteRule ^$ public/ [L] | ||
RewriteRule (.*) public/$1 [L] | ||
|
||
# Redirect to HTTPS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's enough to have that just in public/.htaccess
@@ -1,6 +1,18 @@ | |||
+Options All –Indexes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess Options
and <Files>
directives could come in another PR
@@ -16,6 +28,7 @@ | |||
# absolute physical path to the directory that contains this htaccess file. | |||
# RewriteBase / | |||
|
|||
RewriteCond %{REQUEST_FILENAME} !-d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is not necessary, as it allows directory listing (some hosts don't support Options All –Indexes
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This directive checks for a directory in the file system. These are the usual recommendations for configuring Apache Server. Here is an example of recommendations from the Slim documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks
@piotr-cz is this PR good to go? I'm not good with Apache configs as I don't use it. |
@l0gicgate |
@piotr-cz thanks for your response |
No description provided.