Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Python versions and CI #486

Merged
merged 7 commits into from
Jan 13, 2025

Conversation

johnfraney
Copy link
Contributor

@johnfraney johnfraney commented Jan 13, 2025

Updates supported Python versions to be 3.9-3.13 and updates CI to use the built-in textblob.download_corpora command. Also updates corpora module names to fix a missing corpora error when running:

python -m textblob.download_corpora

Notes

This should fix CI errors and #482 and #474 but removes NLTK v3.8 support

This requires updating the repo's required status checks to be Python 3.9 and 3.13

Updates corpora module names to fix a missing corpora error when
running:

python -m textblob.download_corpora

This should fix CI errors and #482 and #474
@johnfraney johnfraney marked this pull request as draft January 13, 2025 17:27
Updates supported Python versions to be 3.9-3.13 and updates CI to use
the built-in textblob.download_corpora command
@johnfraney johnfraney force-pushed the update-python-versions branch from 845112a to 3dd52b4 Compare January 13, 2025 17:29
@johnfraney johnfraney marked this pull request as ready for review January 13, 2025 17:32
Copy link
Owner

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! been meaning to get to this for a while but haven't had the time.

once lowest is added back, this should be good to merge!

.github/workflows/build-release.yml Show resolved Hide resolved
Adds back the "lowest" env in Tox/CI to ensure support in the lowest supported Python + NLTK versions
Copy link
Owner

@sloria sloria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks so much.

i'll fix up the branch rules and merge this later today. in the meantime, can you add yourself to AUTHORS.rst please?

@johnfraney
Copy link
Contributor Author

@sloria Oh! You bet. I'll do that now

@sloria sloria merged commit 8df5642 into sloria:dev Jan 13, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants