-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Python versions and CI #486
Conversation
Updates supported Python versions to be 3.9-3.13 and updates CI to use the built-in textblob.download_corpora command
845112a
to
3dd52b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! been meaning to get to this for a while but haven't had the time.
once lowest
is added back, this should be good to merge!
Adds back the "lowest" env in Tox/CI to ensure support in the lowest supported Python + NLTK versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! thanks so much.
i'll fix up the branch rules and merge this later today. in the meantime, can you add yourself to AUTHORS.rst please?
@sloria Oh! You bet. I'll do that now |
Updates supported Python versions to be 3.9-3.13 and updates CI to use the built-in
textblob.download_corpora
command. Also updates corpora module names to fix a missing corpora error when running:python -m textblob.download_corpora
Notes
This should fix CI errors and #482 and #474 but removes NLTK v3.8 support
This requires updating the repo's required status checks to be Python 3.9 and 3.13