Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove required argument from parser methods #403

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Remove required argument from parser methods #403

merged 1 commit into from
Jan 23, 2025

Conversation

sloria
Copy link
Owner

@sloria sloria commented Jan 23, 2025

required is redundant with not passing a default value to parser methods.

it was never documented so arguably not a breaking change, but marking it as such anyway in the changelog in case anyone found it on accident.

@sloria sloria merged commit f460dbe into main Jan 23, 2025
10 checks passed
@sloria sloria deleted the rm-required branch January 23, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant