Add support for Samsung Galaxy A71 #44
Conversation
| @@ -0,0 +1,788 @@ | |||
| // SPDX-License-Identifier: BSD-3-Clause | |||
| /* | |||
| * Copyright (c) 2023, Danila Tikhonov <[email protected]> | |||
There was a problem hiding this comment.
Add your copyright too if you want
| }; | ||
|
|
||
| /* Limit CPU clock to 2.2 GHz */ | ||
| &cpu6_opp14 { |
| chassis-type = "handset"; | ||
|
|
||
| qcom,msm-id = <QCOM_ID_SM7150 0>; | ||
| qcom,board-id = <34 0>, /* Rev0.0 */ |
There was a problem hiding this comment.
msm-id and board-id are not required when using header v2. If there is no reason to use another header version, then drop it
| wifi0 = &wifi; | ||
| }; | ||
|
|
||
| battery: battery { |
There was a problem hiding this comment.
Are you sure Samsung uses qcom pmic for fg?
There was a problem hiding this comment.
qcom,qgauge@4800 is enabled in the downstream device tree if that's what you mean.
| qcom,pmic-id = "a"; | ||
|
|
||
| vreg_s4a_1p1: smps4 { | ||
| regulator-min-microvolt = <824000>; |
There was a problem hiding this comment.
Add the regulator-name property to each regulator
| sde_esd_active: sde-esd-state { | ||
| pins = "gpio63"; | ||
| function = "gpio"; | ||
| drive-strength = <0x08>; | ||
| bias-disable = <0x00>; | ||
| }; | ||
|
|
||
| sde_esd_suspend: sde-esd-state { |
There was a problem hiding this comment.
Same pin configuration as sde_dsi suspend. Extend the pin list of sde_dsi_suspend instead of a separate node
| }; | ||
|
|
||
| &dispcc { | ||
| status = "okay"; |
There was a problem hiding this comment.
I don't see dispcc being disabled:
https://github.com/sm7150-mainline/linux/blob/v6.14/arch/arm64/boot/dts/qcom/sm7150.dtsi#L3973
|
|
||
| &i2c0 { | ||
| clock-frequency = <100000>; | ||
| status = "okay"; |
There was a problem hiding this comment.
Maybe you could at least leave a comment on what devices are connected? How can we be sure that this bus is used at all? Otherwise just don't enable i2cX until needed. I'm almost certainly sure that one of these buses is not used on your board, and the pins from the bus were reused. This is why you have a crashes when you enable gpi1
| @@ -44,7 +44,7 @@ | |||
| }; | |||
|
|
|||
| / { | |||
| model = "Samsung A71"; | |||
| @@ -1062,4 +1062,14 @@ config DRM_PANEL_XINPENG_XPP055C272 | |||
| Say Y here if you want to enable support for the Xinpeng | |||
There was a problem hiding this comment.
Write dt-bindings for the panel driver
| * If it's not set at all the display won't show anything because reset-gpios is required by the driver. | ||
| */ | ||
| reset-gpios = <&tlmm 9 GPIO_ACTIVE_HIGH>; // TODO: Check this again or fix in driver | ||
| reset-gpios = <&tlmm 11 GPIO_ACTIVE_HIGH>; |
There was a problem hiding this comment.
your reset gpio is almost certainly active low and that should fix all your problems
This includes device-tree and generated panel driver.