Skip to content

Add device-tree for Samsung Galaxy A71 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

WiiPlayer2
Copy link

No description provided.

Gelbpunkt and others added 30 commits March 25, 2025 03:18
Phones don't have keyboards! Introduce a phone-specific config fragment
and associated environment file to make U-Boot more useful on these
devices. This allows for navigating via the buttons and enabling
various USB gadget modes or displaying info about U-Boot.

Reviewed-by: Simon Glass <[email protected]>
Signed-off-by: Caleb Connolly <[email protected]>
Introduce a new config option: RETRY_BOOTCMD. When enabled this causes
hush shell to re-run "bootcmd" when the auto-boot counter times out.

Signed-off-by: Caleb Connolly <[email protected]>
To enable more complex sequencing of the bootmenu, autoboot, and
bootretry, handle changes to the bootretry variable between tries. This
makes it possible to turn bootretry off (e.g. to drop to a shell) and
then back on again.

This makes it possible to have a persistent bootmenu (the only way to
navigate U-Boot on devices like smartphones which lack a physical
keyboard) by having bootcmd be defined to launch the bootmenu. This
allows for menu options like enabling USB mass storage gadget to return
back to the boot menu once the gadget is shut down.

Reviewed-by: Tom Rini <[email protected]>
Signed-off-by: Caleb Connolly <[email protected]>
Add some documentation which attempts to describe Qualcomm smartphone
support with the qcom-phone.config fragment, as well as a high level
debugging guide for diagnosing U-Boot issues when UART and framebuffer
are unavailable.

Reviewed-by: Simon Glass <[email protected]>
Signed-off-by: Caleb Connolly <[email protected]>
The length of a property includes '\0' in a string type one, so
the length passed by needs to have that in account, if not,
when getting the property value it will fail because it
has the wrong size.

Signed-off-by: Rui Miguel Silva <[email protected]>
Tested-by: [email protected] # db845c
Reviewed-by: Caleb Connolly <[email protected]>
Reviewed-by: Neil Armstrong <[email protected]>
Add regulator driver that allow some Qualcomm PMIC to
feed VBUS output to peripherals that are connected.

Signed-off-by: Rui Miguel Silva <[email protected]>
Acked-by: Caleb Connolly <[email protected]>
Reviewed-by: Neil Armstrong <[email protected]>
Reviewed-by: Caleb Connolly <[email protected]>
These are necessary for USB gadget to come up properly, now that
qcom_gate_clk_en fails on unknown clocks.

Signed-off-by: Sam Day <[email protected]>
Reviewed-by: Neil Armstrong <[email protected]>
These are all usually enabled, hence we don't (yet) bother configuring
their RCG src clocks.

Add them to remove the errors about missing clocks when the UFS and MMC
drivers probe.

Signed-off-by: Caleb Connolly <[email protected]>
Reviewed-by: Neil Armstrong <[email protected]>
Necessary for UFS to successfully probe all clocks.

Signed-off-by: Caleb Connolly <[email protected]>
This is required for gadget modes to work on most platforms. It must be
disabled for dragonboard410c since that doesn't use dwc3. USB on other
MSM8916 platforms isn't supported by qcom_defconfig anyway.

Signed-off-by: Caleb Connolly <[email protected]>
Enable fastboot support over USB, using MMC as the backend. This will be
the internal eMMC on devices that have it, or the sdcard slot on devices
with UFS (if available).

We don't use a fixed address for the fastboot buffer because it's
allocated at runtime per-board. Entering fastboot mode should be done by
executing "run fastboot" or manually running:

fastboot -l $fastboot_addr_r usb 0

Signed-off-by: Caleb Connolly <[email protected]>
Add a clock driver for the SM7150 SoC. This driver can enable necessary
clocks for UART, UFS, USB, and MMC.

Co-authored-by: Jens Reidel <[email protected]>
Signed-off-by: Danila Tikhonov <[email protected]>
This SoC features a pinctrl block with north, south, and west tiles
accessible to the AP.

Signed-off-by: Danila Tikhonov <[email protected]>
This is used for the volume keys on some SC7180/SM7125/SM7150 devices.

Signed-off-by: Danila Tikhonov <[email protected]>
Stub the RPMh clock controller on SC7180

Signed-off-by: Jens Reidel <[email protected]>
These are required for SD card on SM7150.

Signed-off-by: Jens Reidel <[email protected]>
@SanyaPilot
Copy link

I think you should squash all your commits to one, this looks messy

@WiiPlayer2
Copy link
Author

I think you should squash all your commits to one, this looks messy

Is this really necessary? Doesn't GitHub support squash merges? Or is there another reason?

@SanyaPilot
Copy link

SanyaPilot commented Apr 4, 2025

I think you should squash all your commits to one, this looks messy

Is this really necessary? Doesn't GitHub support squash merges? Or is there another reason?

Yea, GitHub supports squash merges, but it's just cleaner when you send a properly formed commit

@Gelbpunkt Gelbpunkt force-pushed the master branch 2 times, most recently from 4a7f216 to 70c600c Compare April 14, 2025 01:52
@Gelbpunkt Gelbpunkt force-pushed the master branch 7 times, most recently from eb4235a to 0f36c4a Compare April 30, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants