Fix lineage download button (#120) #121
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change file type to svg - Download whole view, not just current viewport - Add confirmation dialog
zzeekk
requested changes
Jul 18, 2025
Contributor
zzeekk
left a comment
zzeekk
left a comment
There was a problem hiding this comment.
Tried it out, but it is very slow and creates huge svg files, e.g. for a graph with 18 nodes it takes ~30s and creates a ~50MB file.
Looking in the SVG it seems that 100kB of styles are repeated for every nodes and edges.
I would rather disable it than keeping it like this. Lets not put much more time into it, if there is no easy solution.
Contributor
Author
|
I only tried smaller graphs as I do not have large samples. I agree that it is not worth it to spend more time on it. So I will just disable the button, but leave the code in their. Is that alright or should I remove the code completely? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the lineage download button. In particular the following changes were made: