Error codes on reportable capability errors #1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ettec
commented
Nov 21, 2025
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ettec
force-pushed
the
error-codes-on-reportable-capability-errors
branch
from
ec93c6d to
f2f0b46
Compare
ettec
force-pushed
the
error-codes-on-reportable-capability-errors
branch
from
f2f0b46 to
46bd1a7
Compare
ettec
force-pushed
the
error-codes-on-reportable-capability-errors
branch
from
84b07f3 to
d98d621
Compare
product-security-plaid-production
bot
requested review from
DylanTinianov,
justinkaseman,
nolag and
silaslenihan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates capability error handling from a legacy system using RemoteReportableError and ReportableUserError to a new structured error system with explicit error codes, visibility levels (public/private), and origin types (system/user). The change improves error categorization and enables better error reporting across distributed nodes.
Key changes:
- Introduces a new
caperrorspackage with structured error types including error codes, visibility, and origin - Updates error serialization/deserialization to support the new format while maintaining backwards compatibility
- Replaces legacy error wrapper types with the new capability error system
- Updates all generated capability server interfaces to return
caperrors.Errorinstead of genericerror
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/capabilities/errors/error.go | Defines core error types with visibility, origin, and error code fields |
| pkg/capabilities/errors/error_codes.go | Defines gRPC-based error codes and conversion utilities |
| pkg/capabilities/errors/error_serialization.go | Implements error serialization for cross-node communication |
| pkg/capabilities/errors/error_serialization_test.go | Tests serialization, deserialization, and backwards compatibility |
| pkg/loop/internal/core/services/capability/capabilities.go | Updates error handling to use new capability error system |
| pkg/loop/internal/core/services/capability/capabilities_test.go | Updates tests to validate new error types and properties |
| pkg/capabilities/remote_reportable_error.go | Removes legacy error type |
| pkg/capabilities/reportable_user_error.go | Removes legacy error type |
| pkg/capabilities/remote_unreportable_error.go | Removes legacy error type |
| Various server_gen.go files | Updates generated interfaces to return caperrors.Error |
Comments suppressed due to low confidence (1)
pkg/capabilities/errors/error_serialization_test.go:1
- Corrected spelling of 'compatability' to 'compatibility'.
package errors_test
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
george-dorin
approved these changes
Nov 25, 2025
agparadiso
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates capability error handling from a legacy system using RemoteReportableError and ReportableUserError to a new structured error system with explicit error codes, visibility levels (public/private), and origin types (system/user). The change improves error categorization and enables better error reporting across distributed nodes.
Key changes:
Introduces a new caperrors package with structured error types including error codes, visibility, and origin
Updates error serialization/deserialization to support the new format while maintaining backwards compatibility
Replaces legacy error wrapper types with the new capability error system
Updates all generated executable capability server interfaces to return caperrors.Error instead of generic error