-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed multiple issues where video stream resuming fails #1538
Fixed multiple issues where video stream resuming fails #1538
Conversation
@SatbirTanda I know you found additional issues with handling error messages from the security managers but can you also test this PR and see if it fixes some issues (r.e. #1527)? |
Hi @NicoleYarroch, I was able to test this branch with my encrypted streaming app and I am still consistently seeing this issue: #1527 |
@SatbirTanda Thanks for testing the PR. Can you see from the logs if any of these scenarios is occurring:
|
Yes I see 3) a NAK occurs on resumption - at which point the streaming state does not get set to STOPPED because an error is not handled properly #1527, it occurs specifically before the ssl handshake and needs to be handled in SDL iOS, looks like there was a TODO from 4 yrs ago: sdl_ios/SmartDeviceLink/SDLProtocol.m Line 725 in e948511
syncFrame is not being called to send any frames, its an infinite loop in sdl_processSecurityMessage
|
Closing in favor of PR #1551 |
Fixes #1527
This PR is ready for review.
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
I added unit test for testing stopping the
SDLStreamingVideoScaleManager
,SDLStreamingAudioLifecycleManager
andSDLH264VideoEncoder
when the session between the accessory and device is closed.Core Tests
Core version / branch / commit hash / module tested against: SYNC 3.4 BUILD 19353_DEVTEST_r133796
HMI name / version / branch / commit hash / module tested against: same as above
Summary
SDLH264VideoEncoder
class randomly invalidates itself when the device app is backgrounded. Handling was added to reset the pixel buffer pool when necessary, otherwise video frames will not be sent.When testing you may run into this issue 1540 where no video is streamed by the
CarWindow
due to the video encoder failing when the app on the device is backgrounded. You will see error logs now when thepixelBuffer
fails.Changelog
Bug Fixes
CLA