[ASQ-1255] Updated sinatra dependency #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micaelacunhadev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When upgrading ASQ's Ruby version to 3.4 in the scope of ticket ASQ-1245, the following script stopped working
and so did the command below that calls the first command:
After some digging into the cause of the problem, we noticed that
sinatra, which is called in the script, wouldn't start. This indicated that an older version ofsinatra, likely to be incompatible with the new ruby version, could likely be the culprit.Upon updating the
sinatradependency onraddocs.gemspecand specifying a version greater or equal to 3.0 onGemfile, the problem was fixed.Motivation and Context
ASQ-1255 - Upgrade SmartLogic gems used in ASQ
ASQ-1245 - Upgrade Ruby from 3.2 to 3.4