Skip to content

🐛 fix: complete Effect 4 runtime compatibility - #1463

Merged
roninjin10 merged 15 commits into
smithersai:mainfrom
N0xMare:nox/fix-effect4-workflow-make
Aug 1, 2026
Merged

🐛 fix: complete Effect 4 runtime compatibility#1463
roninjin10 merged 15 commits into
smithersai:mainfrom
N0xMare:nox/fix-effect4-workflow-make

Conversation

@N0xMare

@N0xMare N0xMare commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • complete the Effect 4 beta.102 workflow bridge, SingleRunner, managed-runtime, callback, cancellation, schema, metric, and service-tag migrations
  • make child-process timeout and interruption cleanup bounded and descendant-safe across POSIX, with guarded and bounded taskkill fallback behavior on Windows
  • migrate sandbox entities and transports while preserving their public service-key declarations
  • update VCS execution to ChildProcessSpawner, harden jj timeouts and cleanup, and align public declarations and docs
  • align observability log levels, ServiceClass tags, metric APIs, public logging exports, generated declarations, and contract tests
  • refresh generated declarations and documentation mirrors required by the corrected public APIs

Why this belongs together

The original Workflow.make repair exposed the adjacent Effect 4 runtime and declaration incompatibilities that prevented the bridge from operating reliably end to end. This update keeps those compatibility repairs together while excluding generic checkpoint and Nanocodex backend feature work.

Verification

  • root typecheck, lint/format, declaration consistency, and declaration consumer checks pass
  • driver: 199 pass, including bounded Windows taskkill fallback and actual target termination
  • sandbox: 198 pass, 2 intentional environment skips; emitted-declaration consumer compile passes
  • memory: 165 pass; emitted service-key declarations pass the strict consumer gate
  • observability: 334 pass
  • VCS: 95 pass
  • server: 714 pass, 1 skip
  • smithers facade: 310 pass, 7 skip
  • CLI: all 218 test batches pass
  • docs/llms artifacts regenerated; workspace declarations rebuilt, with the CLI build passing under an expanded Node heap
  • frozen pnpm and Bun lockfile verification passes
  • CI, fault injection, and automated review all pass on the rebased head

Stack and merge order

This is layer 1 of 3 in the current compatibility/feature stack:

  1. 🐛 fix: complete Effect 4 runtime compatibility #1463 — Effect 4 runtime compatibility (this PR), head 7bb8e91b209efb30ce7f0f60bab9b7599292762d
  2. feat: add durable generic agent checkpoints #1449 — durable generic agent checkpoints, head f0c287dfb5c0f37f4657d25148c8ef5bc4cb6f30
  3. feat: add Nanocodex agent backend #1461 — Nanocodex backend, head f9a247f9c82033ab2cdaf6034c76e85b0dd35f00

Merge in that order. Because these are cross-repository PRs, all three bases intentionally remain main; the later PR diffs are cumulative until their predecessors land.

@N0xMare
N0xMare force-pushed the nox/fix-effect4-workflow-make branch from 4145d21 to 852e842 Compare July 31, 2026 07:39
@N0xMare N0xMare changed the title 🐛 fix(engine): construct workflow bridge with Effect 4 API 🐛 fix: complete Effect 4 runtime compatibility Jul 31, 2026
roninjin10 and others added 14 commits July 31, 2026 19:26
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…low-make

# Conflicts:
#	apps/observability/src/metrics/index.d.ts
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ants

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@roninjin10
roninjin10 merged commit c8a2077 into smithersai:main Aug 1, 2026
1 check passed
roninjin10 added a commit to N0xMare/smithers that referenced this pull request Aug 11, 2026
Rebasing smithersai#1461 past the merged smithersai#1463/smithersai#1449 layers dropped the branch's
merge-commit resolutions and left three kinds of residue:

- every new Nanocodex file still imported the pre-rename
  `smithers-orchestrator` / `@smithers-orchestrator/*` specifiers;
- the CI hardening that lived only in a merge commit (workflow-level
  `permissions: contents: read`, `persist-credentials: false` on the
  `test` and `coverage` checkouts) was lost;
- `scripts/qualify-nanocodex-release.{mjs,test.mjs}` regained the
  `downloadArchive` network path the final commit had deleted.

Restore all three so the branch matches the PR head's intent on top of
current main.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
roninjin10 added a commit to N0xMare/smithers that referenced this pull request Aug 11, 2026
Rebasing smithersai#1461 past the merged smithersai#1463/smithersai#1449 layers dropped the branch's
merge-commit resolutions and left three kinds of residue:

- every new Nanocodex file still imported the pre-rename
  `smithers-orchestrator` / `@smithers-orchestrator/*` specifiers;
- the CI hardening that lived only in a merge commit (workflow-level
  `permissions: contents: read`, `persist-credentials: false` on the
  `test` and `coverage` checkouts) was lost;
- `scripts/qualify-nanocodex-release.{mjs,test.mjs}` regained the
  `downloadArchive` network path the final commit had deleted.

Restore all three so the branch matches the PR head's intent on top of
current main.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
roninjin10 added a commit that referenced this pull request Aug 11, 2026
Rebasing #1461 past the merged #1463/#1449 layers dropped the branch's
merge-commit resolutions and left three kinds of residue:

- every new Nanocodex file still imported the pre-rename
  `smithers-orchestrator` / `@smithers-orchestrator/*` specifiers;
- the CI hardening that lived only in a merge commit (workflow-level
  `permissions: contents: read`, `persist-credentials: false` on the
  `test` and `coverage` checkouts) was lost;
- `scripts/qualify-nanocodex-release.{mjs,test.mjs}` regained the
  `downloadArchive` network path the final commit had deleted.

Restore all three so the branch matches the PR head's intent on top of
current main.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants