restXml and restJson1 should support the httpChecksum trait #2867
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
What do these changes do?
Add the
@httpChecksumtrait to the list of supported traits forrestXmlandrestJson1Why are they important?
Codegens need to know which traits to ignore and which to honor. They do this based on the traits listed in the protocol definition. If codegens ignore the
@httpChecksumtrait, they will generate incorrect S3 code (for example)Testing
Tested
restXmlwith the ABAP SDK, with a preview build of S3 and ran the integration and smoke tests (failed before the change, passed after). Did not test forrestJson1.Links
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.