Skip to content

Conversation

@frij-aws
Copy link
Contributor

Background

  • What do these changes do?
    Add the @httpChecksum trait to the list of supported traits for restXml and restJson1

  • Why are they important?
    Codegens need to know which traits to ignore and which to honor. They do this based on the traits listed in the protocol definition. If codegens ignore the @httpChecksum trait, they will generate incorrect S3 code (for example)

Testing

  • How did you test these changes?
    Tested restXml with the ABAP SDK, with a preview build of S3 and ran the integration and smoke tests (failed before the change, passed after). Did not test for restJson1.

Links

  • Based on internal discussions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@frij-aws frij-aws requested a review from a team as a code owner November 26, 2025 21:20
@frij-aws frij-aws requested a review from joewyz November 26, 2025 21:20
@github-actions
Copy link
Contributor

This pull request does not contain a staged changelog entry. To create one, use the ./.changes/new-change command. For example:

./.changes/new-change --pull-requests "#2867" --type feature --description "restXml and restJson1 should support the httpChecksum trait"

Make sure that the description is appropriate for a changelog entry and that the proper feature type is used. See ./.changes/README or run ./.changes/new-change -h for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant