Skip to content

feat: 아이템은 매일 00시 기준 한번 발급받을 수 있다 (#224) #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
submodule-reader merged 1 commit into from
Jul 13, 2025
Merged

feat: 아이템은 매일 00시 기준 한번 발급받을 수 있다 (#224) #225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...main/java/com/snackgame/server/game/snackgame/core/domain/item/policy/DailyGrantPolicy.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package com.snackgame.server.game.snackgame.core.domain.item.policy
import com.snackgame.server.game.snackgame.core.domain.item.ItemGrantHistory
import com.snackgame.server.game.snackgame.core.domain.item.ItemType
import org.springframework.stereotype.Component
import java.time.LocalDateTime
import java.time.LocalDate

@Component
class DailyGrantPolicy : ItemGrantPolicy {
Expand All @@ -14,7 +14,8 @@ class DailyGrantPolicy : ItemGrantPolicy {
): Boolean {
val latest = histories.filter { it.grantType == GrantType.DAILY }
.maxByOrNull { it.grantedAt } ?: return true
return latest.grantedAt.plusDays(1).isBefore(LocalDateTime.now())

return latest.grantedAt.toLocalDate().isBefore(LocalDate.now())
}

}
25 changes: 21 additions & 4 deletions src/test/java/com/snackgame/server/game/snackgame/core/service/ItemServiceTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,22 +3,23 @@
package com.snackgame.server.game.snackgame.core.service



import com.snackgame.server.fixture.SeasonFixture
import com.snackgame.server.game.snackgame.core.domain.item.Item
import com.snackgame.server.game.snackgame.core.domain.item.ItemGrantHistories
import com.snackgame.server.game.snackgame.core.domain.item.ItemGrantHistory
import com.snackgame.server.game.snackgame.core.domain.item.ItemRepository
import com.snackgame.server.game.snackgame.core.domain.item.ItemService
import com.snackgame.server.game.snackgame.core.domain.item.ItemType
import com.snackgame.server.game.snackgame.core.domain.item.policy.GrantType

import com.snackgame.server.game.snackgame.exception.ItemNotReadyException
import com.snackgame.server.game.snackgame.fixture.ItemFixture
import com.snackgame.server.member.fixture.MemberFixture.땡칠
import com.snackgame.server.member.fixture.MemberFixture.정환
import com.snackgame.server.support.general.ServiceTest
import org.assertj.core.api.Assertions.assertThat
import org.assertj.core.api.Assertions.assertThatThrownBy
import org.junit.jupiter.api.BeforeEach
import org.junit.jupiter.api.Test
import org.springframework.beans.factory.annotation.Autowired
import java.time.LocalDateTime

@ServiceTest
class ItemServiceTest {
Expand All @@ -29,6 +30,9 @@ class ItemServiceTest {
@Autowired
private lateinit var itemRepository: ItemRepository

@Autowired
private lateinit var itemGrantHistories: ItemGrantHistories

@BeforeEach
fun setUp() {
ItemFixture.saveAll()
Expand Down Expand Up @@ -64,4 +68,17 @@ class ItemServiceTest {
assertThat(checked.items.size).isEqualTo(ItemType.entries.size)
}

@Test
fun `아이템은 하루에 한번만 발급받을 수 있다`() {
itemGrantHistories.save(
ItemGrantHistory(
땡칠().id, ItemType.BOMB,
GrantType.DAILY, LocalDateTime.now()
)
)

assertThatThrownBy { itemService.issueItem(땡칠().id, ItemType.BOMB, GrantType.DAILY) }
.isInstanceOf(ItemNotReadyException::class.java)
}

}
Loading