Skip to content

drain 경합으로 인한 409 conflict 해결 #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hwanvely merged 16 commits into from
Apr 6, 2026
Merged

drain 경합으로 인한 409 conflict 해결 #240

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7fe3a3b
피버타임 검증 시 점수가 두배가 되지 않는 현상 해결 (#226)
Hwanvely Aug 26, 2025
b2d0eb4
세션 일시정지시 피버타임을 멈추지 못하던 문제 해결 (#227)
Hwanvely Aug 26, 2025
36fac75
피버타임 관련 문제 해결 (#228)
Hwanvely Sep 2, 2025
f71c8d4
fix: 피버타임 검증 시 일반 스트릭이 검증안되던 문제해결 (#229)
Hwanvely Sep 15, 2025
08e0eba
fix: 피버타임 네트워크 지연 문제 해결 (#231)
Hwanvely Dec 1, 2025
fee6688
피버타임 일시정지 동기화 및 지연시간 문제 해결 (#232)
Hwanvely Jan 21, 2026
0a6e22f
OCI용 CD 파이프라인 마이그레이션 (#234)
Hwanvely Apr 6, 2026
2c39b30
OCI 경로 수정 (#236)
Hwanvely Apr 6, 2026
63435f5
Merge branch 'main' into dev
Hwanvely Apr 6, 2026
996782a
fix: oci 옵션 수정
Hwanvely Apr 6, 2026
1e8247f
fix: shebang 추가
Hwanvely Apr 6, 2026
f287e2b
Merge branch 'main' into dev
Hwanvely Apr 6, 2026
b0e08cc
fix: oci 옵션 수정
Hwanvely Apr 6, 2026
664263f
Merge branch 'main' into dev
Hwanvely Apr 6, 2026
baa02bd
Merge remote-tracking branch 'origin/main' into dev
Hwanvely Apr 6, 2026
e93f1a6
fix: drain 경합으로 인한 409 해결
Hwanvely Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/production-deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,8 @@ jobs:
envs: NLB_ID,ACCESS_TOKEN_SECRET_KEY,REFRESH_TOKEN_SECRET_KEY,DB_URL,DB_USERNAME,DB_PASSWORD
script: |
cd ~/snackgame-server/repo
git fetch origin main
git checkout -B main origin/main
git pull --ff-only origin main --no-recurse-submodules
git fetch origin main
git reset --hard origin/main
chmod +x scripts/deploy-rolling.sh
scripts/deploy-rolling.sh \
${{ secrets.NLB_BACKEND_02_HTTP }} \
Expand Down Expand Up @@ -99,8 +98,7 @@ jobs:
script: |
cd ~/snackgame-server/repo
git fetch origin main
git checkout -B main origin/main
git pull --ff-only origin main --no-recurse-submodules
git reset --hard origin/main
chmod +x scripts/deploy-rolling.sh
scripts/deploy-rolling.sh \
${{ secrets.NLB_BACKEND_01_HTTP }} \
Expand Down
14 changes: 6 additions & 8 deletions scripts/deploy-rolling.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,20 +36,18 @@ set_drain() {
--network-load-balancer-id "$NLB_ID" \
--backend-set-name snackgame-http \
--backend-name "$HTTP_BACKEND" \
--is-drain "$is_drain"
--is-drain "$is_drain" \
--wait-for-state SUCCEEDED \
--max-wait-seconds 120

oci nlb backend update \
--auth instance_principal \
--network-load-balancer-id "$NLB_ID" \
--backend-set-name snackgame-https \
--backend-name "$HTTPS_BACKEND" \
--is-drain "$is_drain"


if [ "$is_drain" = "true" ]; then
echo "[NLB] 드레인 적용 대기 중 (10초)..."
sleep 10
fi
--is-drain "$is_drain" \
--wait-for-state SUCCEEDED \
--max-wait-seconds 120
Comment on lines +39 to +50
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The removal of the explicit sleep timer after setting the drain state might lead to race conditions if the OCI CLI command returns success before the load balancer has fully propagated the drain state to all nodes. While --wait-for-state SUCCEEDED is used, it is safer to retain a small buffer or ensure the OCI API consistency is sufficient for your specific environment.

}


Expand Down
Loading