Conversation
* fix: 피버타임 검증 시 점수가 두배가 되지 않는 문제 해결 * refactor: 바뀐 dto에 맞게 BIZ 및 test 수정
* fix: 피버타임 검증 시 점수가 두배가 되지 않는 문제 해결 * refactor: 바뀐 dto에 맞게 BIZ 및 test 수정 * fix: 피버타임중 일시정지 시 피버타임도 멈추게 한다 * refactor: 인터페이스로 묶는다
* fix: 점수 증가 로직 오류 해결 * fix: 스트릭 발생 시각을 받는다 * refactor: 네이밍 수정 * fix(test): 스트릭 발생 시각 추가
* fix: 치팅 및 네트워크 지연 해결 * comment: 디버깅을 위한 로그 추가 * fix: session과 fevertime 일시정지 동기화
* fix: 치팅 및 네트워크 지연 해결 * comment: 디버깅을 위한 로그 추가 * fix: session과 fevertime 일시정지 동기화 * fix: 세션 예외 오류 해결 * feat: multipart 예외 핸들링 * refactor: CD 파이프라인 OCI로 마이그레이션 * fix: end response 분리
* fix: 치팅 및 네트워크 지연 해결 * comment: 디버깅을 위한 로그 추가 * fix: session과 fevertime 일시정지 동기화 * fix: 세션 예외 오류 해결 * feat: multipart 예외 핸들링 * refactor: CD 파이프라인 OCI로 마이그레이션 * fix: end response 분리 * fix: oci 경로 수정
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates Spring Boot Actuator and Micrometer for Prometheus monitoring across environments and updates the rolling deployment script to utilize OCI CLI wait states for backend updates. A critical configuration error was identified in application-production.yml where the session cookie same-site property was incorrectly moved under the spring block instead of server, which would cause the setting to be ignored.
Comment on lines
+9
to
24
| servlet: | ||
| session: | ||
| cookie: | ||
| same-site: none | ||
|
|
||
| security: | ||
| jwt: | ||
| token: | ||
| access-secret-key: ${ACCESS_TOKEN_SECRET_KEY} | ||
| access-expiry-days: ${ACCESS_TOKEN_EXPIRY_DAYS} | ||
| refresh-secret-key: ${REFRESH_TOKEN_SECRET_KEY} | ||
| refresh-expiry-days: ${REFRESH_TOKEN_EXPIRY_DAYS} | ||
|
|
||
| server: | ||
| port: ${APPLICATION_PORT} | ||
| forward-headers-strategy: native |
There was a problem hiding this comment.
Spring Boot 2.7 버전에서 세션 쿠키의 SameSite 설정은 spring.servlet이 아닌 server.servlet 하위에 위치해야 합니다. 현재 설정은 spring: 블록 내부에 잘못 배치되어 있어 운영 환경에서 세션 쿠키 설정이 무시될 수 있습니다. 이를 server: 블록 하위로 다시 이동해야 합니다.
security:
jwt:
token:
access-secret-key: ${ACCESS_TOKEN_SECRET_KEY}
access-expiry-days: ${ACCESS_TOKEN_EXPIRY_DAYS}
refresh-secret-key: ${REFRESH_TOKEN_SECRET_KEY}
refresh-expiry-days: ${REFRESH_TOKEN_EXPIRY_DAYS}
server:
port: ${APPLICATION_PORT}
forward-headers-strategy: native
servlet:
session:
cookie:
same-site: none
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.