Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable building/promoting to tracks other than latest #28

Merged
merged 1 commit into from
Jan 19, 2024
Merged

feat: enable building/promoting to tracks other than latest #28

merged 1 commit into from
Jan 19, 2024

Conversation

jnsgruk
Copy link
Member

@jnsgruk jnsgruk commented Jan 18, 2024

This is a first stab at making these workflows more channel agnostic.

Until this point, only latest/candidate and latest/stable were considered. In this commit, we formalise that as latest/candidate as the default in all places, which should be backwards compatible. We also introduce channel as an input in more places and thread it through where necessary.

I think this is all that is needed to ensure that snaps such as gimp can run multiple tracks/channels.

@jnsgruk jnsgruk changed the title feat: enable snapcraft-channel to be passed to actions feat: enable building/promoting to tracks other than latest Jan 18, 2024
Copy link
Member

@merlijn-sebrechts merlijn-sebrechts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's test this with signal-desktop to make sure it's backwards compatible?

@merlijn-sebrechts merlijn-sebrechts merged commit 738060d into snapcrafters:main Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants