Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Dash 3.0 #506

Merged
merged 32 commits into from
Feb 7, 2025
Merged

Updates for Dash 3.0 #506

merged 32 commits into from
Feb 7, 2025

Conversation

AnnMarieW
Copy link
Collaborator

@AnnMarieW AnnMarieW commented Feb 6, 2025

Replacement for PR 499.
Please see #499 for more details and sample apps

Closes #453

This PR replaces #458 which only handled changes for Dash 3. This PR includes updates for Dash 3 that are also compatible with Dash 2.

  • handle removal of loading_state
  • handle deprecation of defaultProps, including new way of setting persistence props
  • handle removal of _dashprivate_loadingState used in the Skeleton component.
  • update Checkbox component which has an icon component prop that needs to be rerender with additional props.
  • update all components that used _dashprivate_layout: Checkbox, Popover, Menu, Hovercard, Timeline, Stepper
  • Check PR # 458 to make sure all changes are applied here too.
  • In package.json, pin "dash-extensions-js": "0.0.8" . Before upgrading, check for Dash 2 compatibility. This package is required for the renderDashComponent function, which may be affected by updates in future Dash versions.
  • Require dash >= 3.0 for install -- temporary change to run tests using dash 3. Reverted for pre-release.
  • Set up tests to run for dash 2 and dash 3

Note - do not use the new typing support because it does not handle Mantine typing correctly.

ignore this comment in the build and add notes to releasing.md to ensure it's not added in the future

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
! Missing proptypes.js in dash_mantine_components/__init__.py !
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Add the following to dash_mantine_components/__init__.py to enable
runtime prop types validation with tsx components:

@AnnMarieW AnnMarieW changed the title Dash 3 0 Updates for Dash 3.0 Feb 6, 2025
@AnnMarieW AnnMarieW mentioned this pull request Feb 6, 2025
9 tasks
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Looks great. I'll note that there are a couple of places (Checkbox and a couple of charts are the ones I noticed) where you omitted a default value of false that was previously explicit. This shouldn't change the behavior at all, it'll just change the docstring, but to my eye leaving these implicit is intuitive.

@AnnMarieW AnnMarieW merged commit 4bc7952 into master Feb 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for Dash 3.0
2 participants