-
Notifications
You must be signed in to change notification settings - Fork 12
Add base for workflow uploading release artifacts #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Oh, and most likely separate jobs are needed to generate and publish artifacts for macOS and Windows. |
Hi and thanks for starting this!
🤦 No :( I didn't realize this was happening, thanks for pointing that out. I will push a fix to this branch.
I was hoping we could simply fetch and upload all the artifacts from the "cmake" workflow, which should include all the platforms. Presumably this can be done in a single job? |
df6174c
to
07cf8fa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
=======================================
Coverage 94.01% 94.01%
=======================================
Files 30 30
Lines 1754 1754
=======================================
Hits 1649 1649
Misses 105 105 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Yes. Using |
It works! 🎉 Thank you |
Sorry for lack of responses, I was enjoying some time away from keyboard. I'm glad you were able to make this work. |
This is related to #175.
I am not sure how the release artifacts are prepared (the single-file header-only one I think I can figure out) or whether the zip file inside of zip file is intentional, but this workflow should allow performing the necessary steps to automate the upload of release artifacts.
It will execute automatically on published release.
The "Prepare artifacts" step can be used to generate the necessary zip files. The "Upload artifacts" step can be used to upload the prepared files.
with.files
can be filled like this: