Skip to content

Add base for workflow uploading release artifacts #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 22, 2025

Conversation

kkarbowiak
Copy link
Contributor

This is related to #175.

I am not sure how the release artifacts are prepared (the single-file header-only one I think I can figure out) or whether the zip file inside of zip file is intentional, but this workflow should allow performing the necessary steps to automate the upload of release artifacts.

It will execute automatically on published release.

The "Prepare artifacts" step can be used to generate the necessary zip files. The "Upload artifacts" step can be used to upload the prepared files. with.files can be filled like this:

with:
  files: |
    snitch-header-only.zip
    snitch-ubuntu64-libc++-static.zip
    snitch-ubuntu64-libstdc++-static.zip
    # etc.

@kkarbowiak
Copy link
Contributor Author

Oh, and most likely separate jobs are needed to generate and publish artifacts for macOS and Windows.

@cschreib
Copy link
Member

Hi and thanks for starting this!

whether the zip file inside of zip file is intentional

🤦 No :( I didn't realize this was happening, thanks for pointing that out. I will push a fix to this branch.

Oh, and most likely separate jobs are needed to generate and publish artifacts for macOS and Windows.

I was hoping we could simply fetch and upload all the artifacts from the "cmake" workflow, which should include all the platforms. Presumably this can be done in a single job?

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.01%. Comparing base (5143f38) to head (07cf8fa).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files          30       30           
  Lines        1754     1754           
=======================================
  Hits         1649     1649           
  Misses        105      105           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5143f38...07cf8fa. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cschreib
Copy link
Member

I was hoping we could simply fetch and upload all the artifacts from the "cmake" workflow, which should include all the platforms. Presumably this can be done in a single job?

Yes. Using dawidd6/action-download-artifact to download artifacts from the "cmake" workflow, and then your suggested softprops/action-gh-release to upload the artifacts to the release. I tested that in a playground repo and it seems to work fine, so we can merge this here and see what happens ;)

@cschreib cschreib marked this pull request as ready for review March 22, 2025 12:18
@cschreib cschreib merged commit cec4a04 into snitch-org:main Mar 22, 2025
@cschreib
Copy link
Member

It works! 🎉 Thank you

@kkarbowiak kkarbowiak deleted the upload-artifacts branch March 25, 2025 00:36
@kkarbowiak
Copy link
Contributor Author

Sorry for lack of responses, I was enjoying some time away from keyboard.

I'm glad you were able to make this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants