Skip to content

NO-SNOW: no more tests assertion details #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −10
Open

NO-SNOW: no more tests assertion details #2519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
653f716
NO-SNOW: no more tests assertion details
sfc-gh-fpawlowski Sep 5, 2025
c3ac4ce
Merge branch 'main' into NO-SNOW-fix-test-message
sfc-gh-fpawlowski Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions test/integ/test_large_result_set.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,11 +168,15 @@ def test_query_large_result_set(conn_cnx, db_parameters, ingest_data, caplog):
if expected_token_prefix in line:
aws_request_present = True
# getattr is used to stay compatible with old driver - before SECRET_STARRED_MASK_STR was added
assert (
expected_token_prefix
+ getattr(SecretDetector, "SECRET_STARRED_MASK_STR", "****")
in line
), "connectionpool logger is leaking sensitive information"
masked_signature = expected_token_prefix + getattr(
SecretDetector, "SECRET_STARRED_MASK_STR", "****"
)
if masked_signature not in line:
# Use SecretDetector to mask the line before showing it in error
_, masked_line, _ = SecretDetector.mask_secrets(line)
raise AssertionError(
f"connectionpool logger is leaking sensitive information. Masked line: {masked_line}"
)

assert (
aws_request_present
Expand Down
14 changes: 9 additions & 5 deletions test/integ/test_put_get_with_azure_token.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,15 @@ def test_put_get_with_azure(tmpdir, conn_cnx, from_path, caplog):
if "blob.core.windows.net" in line and expected_token_prefix in line:
azure_request_present = True
# getattr is used to stay compatible with old driver - before SECRET_STARRED_MASK_STR was added
assert (
expected_token_prefix
+ getattr(SecretDetector, "SECRET_STARRED_MASK_STR", "****")
in line
), "connectionpool logger is leaking sensitive information"
masked_signature = expected_token_prefix + getattr(
SecretDetector, "SECRET_STARRED_MASK_STR", "****"
)
if masked_signature not in line:
# Use SecretDetector to mask the line before showing it in error
_, masked_line, _ = SecretDetector.mask_secrets(line)
raise AssertionError(
f"connectionpool logger is leaking sensitive information. Masked line: {masked_line}"
)

assert (
azure_request_present
Expand Down
Loading