-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-SNOW: Add modin as dependency for AST tests. #2919
Open
sfc-gh-jrose
wants to merge
2
commits into
main
Choose a base branch
from
jrose_snow_no_snow_fix_ast_modin_test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ast should not have a dependency on modin, we do not use anything from it for the AST tests to the best of my knowledge. Do you have a link/CI run to point why this fix is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the test that breaks:
https://github.com/snowflakedb/snowpark-python/blob/main/tests/ast/data/Dataframe.to_snowpark_pandas.test
The function it is testing imports modin:
https://github.com/snowflakedb/snowpark-python/blob/main/src/snowflake/snowpark/dataframe.py#L1243
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's an example failure: https://github.com/snowflakedb/snowpark-python/actions/runs/12926763404/job/36050719429
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the pointers. What baffles me that this fails, I don't recall the tests failing when the code was checked in. Did something change? To me the snowpark_pandas test is an integration test with the snowpark pandas api, it may make sense to separate these types of tests out. Quickly adding modin may fix this, but I am concerned about 3.8 (despite its EOL). Let's involve @sfc-gh-vbudati here, given she authored the originally code.
@sfc-gh-vbudati: Do you have an idea/suggestion how we could avoid adding modin as dependency and still test the to_snowpark_pandas API? Maybe we can convert this to an integration test and run only with python3.9+?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To my knowledge, the test was working when it was checked in. The error here (https://github.com/snowflakedb/snowpark-python/actions/runs/12926763404/job/36050719429) looks like it's because modin is not being imported.
@sfc-gh-lspiegelberg the
to_snowpark_pandas.test
won't run unless the Python version is 3.9+ (look atload_test_cases()
intest_ast_driver.py
. So it should be fine to import modin after a check to see that the Python version is 3.9+.