Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-SNOW: Add modin as dependency for AST tests. #2919

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

NO-SNOW: Add modin as dependency for AST tests. #2919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77d6ede
NO-SNOW: Add modin as dependency for AST tests.
sfc-gh-jrose Jan 23, 2025
a7f556e
Merge branch 'main' into jrose_snow_no_snow_fix_ast_modin_test
sfc-gh-jrose Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,9 @@ setenv =
unit: SNOWFLAKE_TEST_TYPE = unit
integ: SNOWFLAKE_TEST_TYPE = integ
doctest: SNOWFLAKE_TEST_TYPE = doctest
ast: SNOWFLAKE_TEST_TYPE = ast
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ast should not have a dependency on modin, we do not use anything from it for the AST tests to the best of my knowledge. Do you have a link/CI run to point why this fix is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the test that breaks:
https://github.com/snowflakedb/snowpark-python/blob/main/tests/ast/data/Dataframe.to_snowpark_pandas.test
The function it is testing imports modin:
https://github.com/snowflakedb/snowpark-python/blob/main/src/snowflake/snowpark/dataframe.py#L1243

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an example failure: https://github.com/snowflakedb/snowpark-python/actions/runs/12926763404/job/36050719429

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pointers. What baffles me that this fails, I don't recall the tests failing when the code was checked in. Did something change? To me the snowpark_pandas test is an integration test with the snowpark pandas api, it may make sense to separate these types of tests out. Quickly adding modin may fix this, but I am concerned about 3.8 (despite its EOL). Let's involve @sfc-gh-vbudati here, given she authored the originally code.

@sfc-gh-vbudati: Do you have an idea/suggestion how we could avoid adding modin as dependency and still test the to_snowpark_pandas API? Maybe we can convert this to an integration test and run only with python3.9+?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my knowledge, the test was working when it was checked in. The error here (https://github.com/snowflakedb/snowpark-python/actions/runs/12926763404/job/36050719429) looks like it's because modin is not being imported.

@sfc-gh-lspiegelberg the to_snowpark_pandas.test won't run unless the Python version is 3.9+ (look at load_test_cases() in test_ast_driver.py. So it should be fine to import modin after a check to see that the Python version is 3.9+.

ast:
SNOWFLAKE_TEST_TYPE = ast
SNOWFLAKE_PYTEST_MODIN_DEPS = [modin-development]
# Add common parts into pytest command
SNOWFLAKE_PYTEST_COV_LOCATION = {env:JUNIT_REPORT_DIR:{toxworkdir}}/junit.{envname}-{env:cloud_provider:dev}.xml
SNOWFLAKE_PYTEST_COV_CMD = --cov snowflake.snowpark --junitxml {env:SNOWFLAKE_PYTEST_COV_LOCATION} --cov-report=
Expand Down
Loading