Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1887104: Update OBJECT semantics #2971

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

SNOW-1887104: Update OBJECT semantics #2971

wants to merge 3 commits into from

Conversation

sfc-gh-jrose
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    This change modifies the semantics for OBJECT type when the _use_structured_type_semantics flag is enabled. In this mode both semi-structured and structured OBJECT data will be represented by StructType and MapType only refers to structured MAP data.

Without the flag semi-structured data will continue to refer to MapType(StringType(), StringType()) while structured OBJECT will refer to StructType.

@sfc-gh-jrose sfc-gh-jrose added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Feb 4, 2025
@sfc-gh-jrose sfc-gh-jrose marked this pull request as ready for review February 11, 2025 17:52
@sfc-gh-jrose sfc-gh-jrose requested review from a team as code owners February 11, 2025 17:52
@sfc-gh-yuwang sfc-gh-yuwang deleted the jrose_snow_1887104_struct_type_semantic_change branch February 13, 2025 22:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
@sfc-gh-jrose sfc-gh-jrose restored the jrose_snow_1887104_struct_type_semantic_change branch February 13, 2025 23:02
@sfc-gh-jrose sfc-gh-jrose reopened this Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-jdu sfc-gh-jdu Awaiting requested review from sfc-gh-jdu sfc-gh-jdu is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-yuwang sfc-gh-yuwang Awaiting requested review from sfc-gh-yuwang sfc-gh-yuwang is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jrose @sfc-gh-yuwang