Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-SNOW: Support SEED argument in Dataframe.sample #3004

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

NO-SNOW: Support SEED argument in Dataframe.sample #3004

wants to merge 7 commits into from

Conversation

sfc-gh-dpetersohn
Copy link
Contributor

@sfc-gh-dpetersohn sfc-gh-dpetersohn commented Feb 12, 2025 •
edited by sfc-gh-heshah
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-NNNNNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines

  3. Please describe how your code solves the related issue.

    See accompanying server-side PR.

@sfc-gh-dpetersohn sfc-gh-dpetersohn requested review from a team as code owners February 12, 2025 16:29
@sfc-gh-dpetersohn sfc-gh-dpetersohn added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Feb 12, 2025
@sfc-gh-yuwang sfc-gh-yuwang deleted the devin/project_metadata_query branch February 13, 2025 22:51
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2025
@sfc-gh-aalam sfc-gh-aalam restored the devin/project_metadata_query branch February 13, 2025 23:00
@sfc-gh-aalam sfc-gh-aalam reopened this Feb 13, 2025
@sfc-gh-dpetersohn sfc-gh-dpetersohn changed the title NO-SNOW: Fix projection case where metadata and sql queries differ NO-SNOW: Support SEED argument in Dataframe.sample Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling Awaiting requested review from sfc-gh-aling sfc-gh-aling is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-aalam sfc-gh-aalam Awaiting requested review from sfc-gh-aalam sfc-gh-aalam is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

@sfc-gh-jrose sfc-gh-jrose Awaiting requested review from sfc-gh-jrose sfc-gh-jrose is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-dpetersohn @sfc-gh-yuwang @sfc-gh-aalam @sfc-gh-heshah