SNOW-1899126: Fix malformed sql for functions that create internal alias #3136
+119
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [Row('{"end":"1970-01-01 00:00:10.000","start":"1970-01-01 00:00:00.000"}')], | ||
| ) | ||
| Utils.check_answer( | ||
| df.select(second(to_timestamp(window(df.ts, "10 seconds")["end"]))), |
There was a problem hiding this comment.
For this second example what does the final column name end up being?
sfc-gh-jrose
approved these changes
Mar 13, 2025
| @@ -592,6 +613,11 @@ def analyze( | |||
| str(expr) | |||
| ) # pragma: no cover | |||
|
|
|||
| def internal_alias_extractor(self, expr: Expression) -> Expression: | |||
There was a problem hiding this comment.
one last comment: can you add comment on when this function needs to called when analyzing expression to give some context to future us?
sfc-gh-aling
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1899126
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
In this PR, we do the following:
Column._aliasto mark aliases created internally by snowpark functions._InternalAliasto differentiate between internal and user-created aliases.analyzemethod to ignore internal aliases when it is not top level expression.