Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1959569: Fix test_datatype_suite.py::test_structured_dtypes_select #3160

Merged

Conversation

sfc-gh-jrose
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1959569

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    This PR fixes two tests:

    • test_structured_dtypes_select: The _create_test_dataframe that sets up the dataframe for this test was using structured types regardless of if the server side had them enabled. This created a difference in expected schema between what the describe reducer expected and what the server reported. I've updated the test to only use structured types when enabled server side and when it is not the expected VariantTypes are returned.
    • test_structured_dtypes_iceberg: I'm not sure why the ddl for this test changed, but it appears to be more accurate on the server side now so I suspect something changed there.

@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner March 14, 2025 23:06
@sfc-gh-jrose sfc-gh-jrose added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Mar 14, 2025
@sfc-gh-snowflakedb-snyk-sa
Copy link

sfc-gh-snowflakedb-snyk-sa commented Mar 19, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-jrose sfc-gh-jrose requested a review from a team March 19, 2025 17:26
@sfc-gh-jrose sfc-gh-jrose merged commit 61982e0 into main Mar 19, 2025
35 of 37 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1959569_fix_test_structured_dtypes_select branch March 19, 2025 21:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants