-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a functionality in apply_in_pandas to support spark api #3162
base: main
Are you sure you want to change the base?
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
if key_columns is not None: | ||
import numpy as np | ||
|
||
key_list = [pdf[key].iloc[0] for key in key_columns] | ||
numpy_array = np.array(key_list) | ||
keys = tuple(numpy_array) | ||
if original_columns is not None: | ||
pdf.columns = original_columns | ||
if key_columns is not None: | ||
return func(keys, pdf) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if key_columns is not None: | |
import numpy as np | |
key_list = [pdf[key].iloc[0] for key in key_columns] | |
numpy_array = np.array(key_list) | |
keys = tuple(numpy_array) | |
if original_columns is not None: | |
pdf.columns = original_columns | |
if key_columns is not None: | |
return func(keys, pdf) | |
if original_columns is not None: | |
pdf.columns = original_columns | |
if key_columns is not None: | |
import numpy as np | |
key_list = [pdf[key].iloc[0] for key in key_columns] | |
numpy_array = np.array(key_list) | |
keys = tuple(numpy_array) | |
return func(keys, pdf) |
nit: can we restructure it this way? grouping the if statements together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't work because we are changing the pdf in
if original_columns is not None: pdf.columns = original_columns
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1800723
If the dataframe comes from spark the column names are not same as the spark column names but the function would be assuming the spark column names and operating like that, this change resolves that issue
This adds a functionality of (key, dataframe) which can also be the type of function spark support
Fill out the following pre-review checklist:
The test for this will be added in this PR https://github.com/snowflakedb/sas/pull/725/files, this is a fork introduced for the non public usecase of snowpark library
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
I am extracting the spark names from the column_map which will only be present if this is being sent from the accelerated spark layer.