Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1962180: Support relaxed pandas in pd.read_snowflake for query data sources #3164

Merged
merged 6 commits into from
Mar 19, 2025

Conversation

sfc-gh-helmeleegy
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1962180

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Support relaxed pandas in pd.read_snowflake for query data sources.

@sfc-gh-snowflakedb-snyk-sa
Copy link

sfc-gh-snowflakedb-snyk-sa commented Mar 15, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-helmeleegy sfc-gh-helmeleegy added the NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs label Mar 15, 2025
Copy link
Contributor

@sfc-gh-joshi sfc-gh-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you clarify the intended behavior when an ORDER BY clause is encountered in a query, both with and without relaxed pandas?

Copy link
Contributor

@sfc-gh-nkrishna sfc-gh-nkrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once Jonathan's comments are addressed

@sfc-gh-helmeleegy
Copy link
Contributor Author

Could you clarify the intended behavior when an ORDER BY clause is encountered in a query, both with and without relaxed pandas?

The order by can only guarantee that the input data is ordered in a certain way. But it does not guarantee how the output data (after applying some pandas operations) will be ordered. I updated the docstring accordingly.

@sfc-gh-helmeleegy sfc-gh-helmeleegy force-pushed the helmeleegy-SNOW-1962180 branch from 7c6ba3a to b5bae4b Compare March 18, 2025 21:29
@sfc-gh-helmeleegy sfc-gh-helmeleegy merged commit 30472be into main Mar 19, 2025
40 checks passed
@sfc-gh-helmeleegy sfc-gh-helmeleegy deleted the helmeleegy-SNOW-1962180 branch March 19, 2025 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants