-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1962180: Support relaxed pandas in pd.read_snowflake for query data sources #3164
Conversation
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you clarify the intended behavior when an ORDER BY clause is encountered in a query, both with and without relaxed pandas?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once Jonathan's comments are addressed
The order by can only guarantee that the input data is ordered in a certain way. But it does not guarantee how the output data (after applying some pandas operations) will be ordered. I updated the docstring accordingly. |
7c6ba3a
to
b5bae4b
Compare
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1962180
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Support relaxed pandas in pd.read_snowflake for query data sources.