Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1984396: [Local Testing] Fix bug in Dataframe.except_ #3167

Merged
merged 4 commits into from
Mar 19, 2025

Conversation

sfc-gh-jrose
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose commented Mar 17, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1984396

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    This PR rewrites the local testing case for EXCEPT operator case for finding the difference between two dataframes. The original approach had edge cases that caused data in multiple rows to be included when dropping individual rows. The new approach takes an alternative approach by concatting the right side twice and then removing all rows that have more than one instance.

See #3163 for more information.

@sfc-gh-jrose sfc-gh-jrose added the local testing Local Testing issues/PRs label Mar 17, 2025
@sfc-gh-jrose sfc-gh-jrose requested a review from a team March 17, 2025 19:48
@sfc-gh-jrose sfc-gh-jrose requested review from a team as code owners March 17, 2025 19:48
@sfc-gh-snowflakedb-snyk-sa
Copy link

sfc-gh-snowflakedb-snyk-sa commented Mar 17, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-jrose sfc-gh-jrose merged commit c21760e into main Mar 19, 2025
36 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1984396_local_testing_minus_fix branch March 19, 2025 23:58
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
local testing Local Testing issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants