Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1938099: Fix tests broken by default lob size change #3169

Merged
merged 4 commits into from
Mar 18, 2025

Conversation

sfc-gh-jrose
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1938099

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Several tests have been broken by a server side change in our test accounts. It appears that the default string size has been changed from 16mb to 128mb. I suspect this is caused by some parameter related to the LOB rollout. Confusingly though this only affects select statements and not table creation statements or statements that get various forms of metadata. I've updated all affected tests to either rely on the max string sized specified by the server or to explicitly use 16mb when appropriate.

@sfc-gh-jrose sfc-gh-jrose added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Mar 17, 2025
@sfc-gh-jrose sfc-gh-jrose requested a review from a team as a code owner March 17, 2025 22:39
@sfc-gh-jrose sfc-gh-jrose merged commit 9087c66 into main Mar 18, 2025
36 of 37 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_no_snow_fix_max_string_size_tests branch March 18, 2025 22:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants