Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1916224: Ensure that all APIs have AST support #3170

Merged

Conversation

sfc-gh-heshah
Copy link
Collaborator

@sfc-gh-heshah sfc-gh-heshah commented Mar 18, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    SNOW-1916224

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

    Updates dataframe.na.{replace,fill} to add the new include_decimal parameter to the AST.

    Adds the @publicapi decorator to APIs missing it

    • DataframeWriter.{partition_by, option, options}
    • functions.fl_is_{video, document, compressed, image}
    • Overload of Table.merge
    • GroupingSets.__init__ in relational_grouped_dataframe.py

    Fixes for issues in the following APIs and expectation tests for them:

    • map in dataframe.py
    • Functions.
      • system_reference
      • mean
      • var_samp
      • explode_outer
      • to_boolean
      • arrays_zip
      • window
      • from_json
      • array_remove
      • ln
      • call_builtin
      • builtin
      • acosh
      • asinh
      • atanh
      • bit_length
      • bitmap_bit_position
      • bitmap_bucket_number
      • bitmap_construct_agg
      • cbrt
      • ifnull
      • localtimestamp
      • max_by
      • min_by
      • octet_length
      • position
      • regr_avgx
      • regr_avgy
      • regr_count
      • regr_intercept
      • regr_r2
      • regr_slope
      • regr_sxx
      • regr_sxy
      • regr_syy
      • try_to_binary
      • build_stage_file_url
    • `RelationalGroupedDataframe.{min, max}
    • TableFunctionCall.over
      • Also includes changes to build order_by and partition_by parameters as ExprArgList type fields in the AST
    • Session.sproc.register_from_file
    • Session.udaf.register_from_file
    • Session.udf.register_from_file
    • Session.udtf.register_from_file

This PR is accompanied by a server-side PR.

Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sfc-gh-heshah sfc-gh-heshah force-pushed the heshah-SNOW-1916224-Ensure-that-all-APIs-have-AST-support branch from 33f759d to aab1cd8 Compare March 18, 2025 18:40
@sfc-gh-heshah sfc-gh-heshah added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-ast Change materially affects the Snowpark AST snowpark-server Server-side snowpark work labels Mar 18, 2025 — with Graphite App
@sfc-gh-heshah sfc-gh-heshah marked this pull request as ready for review March 18, 2025 18:48
@sfc-gh-heshah sfc-gh-heshah requested review from a team as code owners March 18, 2025 18:48
@sfc-gh-lspiegelberg
Copy link
Contributor

looks like a few local testing APIs need to get _emit_ast added? Can we fix?

@sfc-gh-heshah sfc-gh-heshah force-pushed the heshah-SNOW-1916224-Ensure-that-all-APIs-have-AST-support branch from aab1cd8 to 3cd84d4 Compare March 19, 2025 07:42
@sfc-gh-snowflakedb-snyk-sa
Copy link

sfc-gh-snowflakedb-snyk-sa commented Mar 19, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-heshah sfc-gh-heshah force-pushed the heshah-SNOW-1916224-Ensure-that-all-APIs-have-AST-support branch from 3cd84d4 to f183d46 Compare March 19, 2025 20:07
@sfc-gh-heshah sfc-gh-heshah force-pushed the heshah-SNOW-1916224-Ensure-that-all-APIs-have-AST-support branch from f183d46 to 25878f7 Compare March 19, 2025 20:11
@sfc-gh-heshah sfc-gh-heshah merged commit db0b32c into main Mar 19, 2025
39 checks passed
@sfc-gh-heshah sfc-gh-heshah deleted the heshah-SNOW-1916224-Ensure-that-all-APIs-have-AST-support branch March 19, 2025 22:29
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md NO-PANDAS-CHANGEDOC-UPDATES This PR does not update Snowpark pandas docs snowpark-ast Change materially affects the Snowpark AST snowpark-server Server-side snowpark work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants