Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1979918 snowpark python client ast mode and min ast version #3188

Conversation

sfc-gh-evandenberg
Copy link
Collaborator

@sfc-gh-evandenberg sfc-gh-evandenberg commented Mar 24, 2025

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1979918 snowpark python client ast mode and min ast version

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
      [x] If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support.
  3. Please describe how your code solves the related issue.

There is logic in snowpark session start up that checks for the client parameters and sets internal _ast_mode and ast_enabled states.

See: https://docs.google.com/document/d/1KwWYMxITaPxxKVU9Itsj1BuBeY04KftilcpwDdlC2Jg/edit?usp=sharing

@sfc-gh-snowflakedb-snyk-sa
Copy link

sfc-gh-snowflakedb-snyk-sa commented Mar 24, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

@sfc-gh-evandenberg sfc-gh-evandenberg force-pushed the evandenberg-SNOW-1979918-snowpark-python-client-ast-mode-and-min-ast-version branch from b9e3e4c to 02c66b7 Compare March 26, 2025 00:53
@sfc-gh-evandenberg sfc-gh-evandenberg added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Mar 26, 2025
@sfc-gh-evandenberg sfc-gh-evandenberg merged commit bcd4f95 into main Mar 29, 2025
38 checks passed
@sfc-gh-evandenberg sfc-gh-evandenberg deleted the evandenberg-SNOW-1979918-snowpark-python-client-ast-mode-and-min-ast-version branch March 29, 2025 02:17
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants