-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNOW-1979918 snowpark python client ast mode and min ast version #3188
Merged
sfc-gh-evandenberg
merged 11 commits into
main
from
evandenberg-SNOW-1979918-snowpark-python-client-ast-mode-and-min-ast-version
Mar 29, 2025
Merged
SNOW-1979918 snowpark python client ast mode and min ast version #3188
sfc-gh-evandenberg
merged 11 commits into
main
from
evandenberg-SNOW-1979918-snowpark-python-client-ast-mode-and-min-ast-version
Mar 29, 2025
+148
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
…CLIENT_MIN_VERSION_FOR_AST
b9e3e4c
to
02c66b7
Compare
sfc-gh-jdu
approved these changes
Mar 26, 2025
sfc-gh-oplaton
approved these changes
Mar 27, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1979918 snowpark python client ast mode and min ast version
Fill out the following pre-review checklist:
[x] If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support.
Please describe how your code solves the related issue.
There is logic in snowpark session start up that checks for the client parameters and sets internal _ast_mode and ast_enabled states.
See: https://docs.google.com/document/d/1KwWYMxITaPxxKVU9Itsj1BuBeY04KftilcpwDdlC2Jg/edit?usp=sharing